Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document possibility to parameter scriptPattern #389

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

jean-michelet
Copy link
Contributor

@jean-michelet jean-michelet commented Jun 22, 2024

Related to #388

@jean-michelet
Copy link
Contributor Author

jean-michelet commented Jun 22, 2024

Just saw your comment Climba, so if you are sure we should not support it, I will close this PR.

EDIT:
I just added some docs to warn users that they can customize scriptPattern.

@jean-michelet jean-michelet changed the title Support tsx by default docs: document possibility to parameter scriptPattern Jun 22, 2024
README.md Outdated Show resolved Hide resolved
Co-authored-by: Gürgün Dayıoğlu <[email protected]>
Signed-off-by: Jean <[email protected]>
README.md Outdated Show resolved Hide resolved
@climba03003 climba03003 requested a review from Fdawgs June 23, 2024 07:23
Co-authored-by: KaKa <[email protected]>
Signed-off-by: Jean <[email protected]>
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for @Fdawgs before merging.

@jean-michelet
Copy link
Contributor Author

I think I should not merge my own PR, so feel free to proceed when you're done.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Frazer Smith <[email protected]>
Signed-off-by: Jean <[email protected]>
@climba03003 climba03003 merged commit 51e3cef into fastify:master Jun 24, 2024
17 checks passed
@jean-michelet jean-michelet deleted the support-tsx branch June 24, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants