Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): Allows all busboy options on plugin registration #536

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

johaven
Copy link
Contributor

@johaven johaven commented Jul 15, 2024

Checklist

Fix
Options like preservePath are not known

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

Can you add a test using tsd?

@johaven
Copy link
Contributor Author

johaven commented Jul 23, 2024

Can you add a test using tsd?

done :)

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johaven
Copy link
Contributor Author

johaven commented Jul 24, 2024

The linter seems to be broken :/

@mcollina
Copy link
Member

Here is a PR that fixes linting #538

@mcollina
Copy link
Member

Can you please rebase your PR?

@mcollina
Copy link
Member

@gurgunday ptal

@mcollina mcollina merged commit ea4661a into fastify:master Jul 29, 2024
11 checks passed
@johaven johaven deleted the fix-typing-allow-busboy-options branch August 3, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants