Test for faye/websocket-driver-node#8 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires faye/websocket-driver-node#8. |
This was referenced Aug 15, 2014
|
I've not reviewed these changes by eye yet but I have run them past the Autobahn test suite and there don't seem to be any regressions. |
If you decide to open a client connection but then close it before the TCP connection succeeds, the websocket-driver change tested by this commit will ensure that it will actually close, rather than ignoring the close() method. The change to API.close also seems correct to me, though I'm not sure if there are any observable changes if you don't do it.
jcoglan
added a commit
that referenced
this pull request
Sep 7, 2014
|
Thanks for merging my PRs. You haven't actually released the change to websocket-driver yet, and you haven't changed this module's package.json to pull in that fix, so the test suite on this module now fails. |
|
New releases of websocket-driver and faye-websocket are now available. Thanks for the patches :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you decide to open a client connection but then close it before the
TCP connection succeeds, the websocket-driver change tested by this
commit will ensure that it will actually close, rather than ignoring the
close() method.
The change to API.close also seems correct to me, though I'm not sure
if there are any observable changes if you don't do it.