feat: Updating OnDemandFeatureView to add Entities and batch_source #4530
+390
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
…otobuf Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
| name_alias=None, | ||
| features=base_feature_view.features, | ||
| desired_features=[], | ||
| timestamp_field=base_feature_view.batch_source.created_timestamp_column # type:ignore[attr-defined] |
There was a problem hiding this comment.
This is admittedly a hack and I don't like it but this should be refactored in 1.0.0
My overall learning from this is that FeatureViews should be really derived from the same object with the same class parameters and make them optionally instantiated.
This should be described more thoroughly for 1.0.0
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
changed the title
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
…ing to put a workaround Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR
FeatureViewProjectionto include the underlying data sources forOnDemandFeatureView. This allows for much richer lineage when constructing metadata about anOnDemandFeatureViews and its data sources.OnDemandFeatureViewto optionally supportentities, which will be required to write anOnDemandFeatureViewto the online storeBaseFeatureViewto include sources to optionally includebath_sourcewrite_to_online_storeboolean toOnDemandFeatureView(note not used)Which issue(s) this PR fixes:
Misc