Smashed some code smells from Sonarqube

federicoiosue · Aug 14, 2020 · db0286b · db0286b
1 parent 7cb5de3
commit db0286b
Show file tree

Hide file tree

Showing 11 changed files with 2 additions and 105 deletions.
diff --git a/omniNotes/src/main/AndroidManifest.xml b/omniNotes/src/main/AndroidManifest.xml
@@ -279,10 +279,6 @@
             <meta-data
                 android:name="description"
                 android:value="@string/dashclock_description" />
-            <!-- A settings activity is optional -->
-            <!-- <meta-data -->
-            <!-- android:name="settingsActivity" -->
-            <!-- android:value=".ExampleSettingsActivity" /> -->
         </service>
 
         <service

diff --git a/omniNotes/src/main/res/animator/slide_back_left.xml b/omniNotes/src/main/res/animator/slide_back_left.xml
@@ -25,16 +25,6 @@
         android:toXDelta="-70%"
         android:toYDelta="0" />
 
-<!--     <scale -->
-<!--         android:duration="@android:integer/config_shortAnimTime" -->
-<!--         android:fromXScale="1" -->
-<!--         android:fromYScale="1" -->
-<!--         android:pivotX="50%" -->
-<!--         android:pivotY="50%" -->
-<!--         android:toXScale="0.2" -->
-<!--         android:toYScale="0.2" > -->
-<!--     </scale> -->
-
     <alpha
         android:duration="@integer/sliding_anim_time_medium"
         android:fromAlpha="1.0"

diff --git a/omniNotes/src/main/res/animator/slide_back_right.xml b/omniNotes/src/main/res/animator/slide_back_right.xml
@@ -25,17 +25,6 @@
         android:toXDelta="0"
         android:toYDelta="0" />
 
-
-<!--     <scale -->
-<!--         android:duration="@android:integer/config_shortAnimTime" -->
-<!--         android:fromXScale="0.2" -->
-<!--         android:fromYScale="0.2" -->
-<!--         android:pivotX="50%" -->
-<!--         android:pivotY="50%" -->
-<!--         android:toXScale="1" -->
-<!--         android:toYScale="1" > -->
-<!--     </scale> -->
-
     <alpha
         android:duration="@integer/sliding_anim_time_short"
         android:fromAlpha="0.0"

diff --git a/omniNotes/src/main/res/animator/slide_left.xml b/omniNotes/src/main/res/animator/slide_left.xml
@@ -25,16 +25,6 @@
         android:toXDelta="0"
         android:toYDelta="0" />
 
-
-<!--     <scale -->
-<!--         android:duration="@android:integer/config_shortAnimTime" -->
-<!--         android:fromXScale="0.2" -->
-<!--         android:fromYScale="0.2" -->
-<!--         android:pivotX="50%" -->
-<!--         android:pivotY="50%" -->
-<!--         android:toXScale="1" -->
-<!--         android:toYScale="1" > -->
-<!--     </scale> -->
     <alpha
         android:duration="@integer/sliding_anim_time_short"
         android:fromAlpha="0.0"

diff --git a/omniNotes/src/main/res/animator/slide_right.xml b/omniNotes/src/main/res/animator/slide_right.xml
@@ -24,17 +24,6 @@
         android:toXDelta="100%"
         android:toYDelta="0" />
 
-
-<!--     <scale -->
-<!--         android:duration="@android:integer/config_shortAnimTime" -->
-<!--         android:fromXScale="1" -->
-<!--         android:fromYScale="1" -->
-<!--         android:pivotX="50%" -->
-<!--         android:pivotY="50%" -->
-<!--         android:toXScale="0.2" -->
-<!--         android:toYScale="0.2" > -->
-<!--     </scale> -->
-
     <alpha
         android:duration="@integer/sliding_anim_time_medium"
         android:fromAlpha="1.0"

diff --git a/omniNotes/src/main/res/drawable/image_borders.xml b/omniNotes/src/main/res/drawable/image_borders.xml
@@ -24,7 +24,6 @@
 </item>
 <item android:top="4dp">
     <shape android:shape="rectangle">
-<!--         <solid android:color="@color/gray_bg" /> -->
         <solid android:color="@color/white" />
     </shape>
 </item>

diff --git a/omniNotes/src/main/res/drawable/list_selector_focused.xml b/omniNotes/src/main/res/drawable/list_selector_focused.xml
@@ -23,12 +23,5 @@
     <solid
         android:color="@color/kitkat_gray_light" >
     </solid>
-
-    <!-- view border color and width -->
-    <!--<stroke-->
-        <!--android:width="2dp"-->
-        <!--android:color="#ffffff" >-->
-    <!--</stroke>-->
->
-
+
 </shape>
diff --git a/omniNotes/src/main/res/drawable/list_selector_pressed.xml b/omniNotes/src/main/res/drawable/list_selector_pressed.xml
@@ -23,12 +23,5 @@
     <solid
         android:color="@color/kitkat_gray_light" >
     </solid>
-
-    <!-- view border color and width -->
-    <!--<stroke-->
-        <!--android:width="2dp"-->
-        <!--android:color="@color/kitkat_gray_light" >-->
-    <!--</stroke>-->
->
-
+
 </shape>
diff --git a/omniNotes/src/main/res/drawable/scroll_bar.xml b/omniNotes/src/main/res/drawable/scroll_bar.xml
@@ -19,16 +19,5 @@
 <shape xmlns:android="http://schemas.android.com/apk/res/android" >
 
     <solid android:color="@color/selected"/>
-<!--     <gradient -->
-<!--         android:angle="45" -->
-<!--         android:endColor="@color/gray_bg" -->
-<!--         android:centerColor="@color/selected" -->
-<!--         android:startColor="@color/gray_bg" /> -->
-
-<!--     <corners android:radius="8dp" /> -->
-
-<!--     <padding -->
-<!--         android:left="0.5dp" -->
-<!--         android:right="0.5dp" /> -->
 
 </shape>
diff --git a/omniNotes/src/main/res/layout/drawer_category_list_footer.xml b/omniNotes/src/main/res/layout/drawer_category_list_footer.xml
@@ -14,23 +14,13 @@
   ~ You should have received a copy of the GNU General Public License
   ~ along with this program.  If not, see <http://www.gnu.org/licenses/>.
   -->
-<!-- <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" -->
-<!--     xmlns:pixlui="http://schemas.android.com/apk/com.neopixl.pixlui" -->
-<!--     android:layout_width="match_parent" -->
-<!--     android:layout_height="wrap_content" -->
-<!--     android:background="@drawable/icon_selector" -->
-<!--     android:gravity="center_vertical" -->
-<!--     android:orientation="horizontal" -->
-<!--     android:paddingLeft="@dimen/horizontal_margin" -->
-<!--     android:paddingStart="@dimen/horizontal_margin"> -->
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:pixlui="http://schemas.android.com/apk/com.neopixl.pixlui"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:background="@drawable/icon_selector"
     android:gravity="center_vertical"
     android:orientation="horizontal"
-    android:paddingLeft="@dimen/horizontal_margin"
     android:paddingStart="@dimen/horizontal_margin">
 
     <ImageView
@@ -39,25 +29,11 @@
         android:padding="4dp"
         android:src="@drawable/ic_settings_black_36dp" />
 
-<!--     <com.neopixl.pixlui.components.textview.TextView -->
-<!--         android:id="@+id/settings" -->
-<!--         android:layout_width="@dimen/navigation_drawer_width" -->
-<!--         android:layout_height="50dp" -->
-<!--         android:gravity="center_vertical" -->
-<!--         android:paddingLeft="@dimen/icon_text_margin" -->
-<!--         android:paddingStart="@dimen/icon_text_margin" -->
-<!--         android:text="@string/settings" -->
-<!--         android:textAllCaps="true" -->
-<!--         android:textAppearance="@style/Text.Normal" -->
-<!--         android:textColor="@color/drawer_text" -->
-<!--         pixlui:typeface="Roboto-Regular.ttf" /> -->
-
     <com.neopixl.pixlui.components.textview.TextView
         android:id="@+id/settings"
         android:layout_width="@dimen/navigation_drawer_width"
         android:layout_height="50dp"
         android:gravity="center_vertical"
-        android:paddingLeft="@dimen/icon_text_margin"
         android:paddingStart="@dimen/icon_text_margin"
         android:text="@string/settings"
         android:textAllCaps="true"

diff --git a/omniNotes/src/main/res/layout/fragment_navigation_drawer.xml b/omniNotes/src/main/res/layout/fragment_navigation_drawer.xml
@@ -28,13 +28,6 @@
         android:layout_gravity="start"
         android:orientation="vertical">
 
-        <!--<ImageView-->
-            <!--android:id="@+id/navdrawer_image"-->
-            <!--android:layout_width="match_parent"-->
-            <!--android:layout_height="?attr/actionBarSize"-->
-            <!--android:src="@drawable/material_wall"-->
-            <!--android:scaleType="centerCrop" />-->
-
         <RelativeLayout
                 android:layout_width="match_parent"
                 android:layout_height="@dimen/navigation_drawer_image_height">