Different reproducible changes #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 71 71
Lines 2091 2101 +10
Branches 305 308 +3
======================================
- Misses 2091 2101 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Ping? |
fridrich
changed the title
|
Pingo ;) |
|
Would it be possible to review and take at least some of the patches. The reproducible manifest or the -notimestamp for javadoc should be reasonably non-controversial. The metadata stuff might look scary, but we run with it for almost 2 years already here in SUSE and it is just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a bit controversial, but if the SOURCE_DATE_EPOCH is not set, everything is like before. Now, with this patch, the uuids are still unique in the package and also around the whole system, but they are the same if the zero-change rebuild is done. We run this since early August and everything works just fine. All xmvn tests and -Prun-its pass.
I rerun the whole build with this particular version of patch, just to be sure and the stuff is reproducible but still uuids are unique if SOURCE_DATE_EPOCH is set.