Add support for embedding SRF external contents #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabiangermann Ich habe das unter Deinem Namen committed, da Du den ganzen Code geschrieben hast. |
fabiangermann
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
@matthiask danke 😅.
Die URLs bzw. das Pattern ist halt evtl. nicht abschliessend gell. Das habe ich einfach anhand der Daten die sie abgefüllt hatten erstellt. Aber da sie keine offizielle Schnittstelle haben ist da wahrscheinlich as good as it gets 🤷.
Ja, ist doch super. Merci für den Review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code gestohlen aus einem Produktionsprojekt.