Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Japanese localization #123

Closed
wants to merge 1 commit into from

Conversation

hkurosawa
Copy link
Contributor

Made resources localizable & added the Japanese localization.

@fikovnik
Copy link
Owner

Thanks a lot! This is great.

Next week, I'm out, but after I will merge it in.

/cheers
Filip

@hkurosawa
Copy link
Contributor Author

Thank you for reviewing, I'm looking forward to it!

@fikovnik fikovnik added this to the 1.6.1 milestone May 22, 2014
@fikovnik fikovnik modified the milestones: 1.6.2, 1.6.1 Jun 7, 2014
@fikovnik
Copy link
Owner

fikovnik commented Jun 7, 2014

I know I'm horribly late. But finally I had couple of hours to spend on ShiftIt and I wanted to pull this in, but I did not manage. Would you mind Updating this pull request against the version which is in the release branch 1.6.1? There are couple of additional strings to translate - all in checkAuthorization method in ShiftItAppDelegate.

Thanks a lot! I really apologize that it took me such a ling time.

@hkurosawa
Copy link
Contributor Author

OK, I'll try to re-create the PR, please wait for a while.

@hkurosawa
Copy link
Contributor Author

created another Pull Requset at #137 . thanks

@hkurosawa hkurosawa closed this Jun 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants