Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ja localization for "Needs Auth" string for 10.8 or earlier. #140

Merged

Conversation

hkurosawa
Copy link
Contributor

  • Added missing localization text ("needs authorization" for 10.8 or earlier)
  • AUTHORIZATION_INFORMATIVE_TEXT_* key string to original string. for mentioned at Previous Window #132.

@hkurosawa hkurosawa changed the title added ja localization for Auth text for 10.8 or earlier. Reverted the ke... added ja localization for "Needs Auth" string for 10.8 or earlier. Jun 19, 2014
fikovnik added a commit that referenced this pull request Jun 19, 2014
Added ja localization for "Needs Auth" string for 10.8 or earlier.
@fikovnik fikovnik merged commit 264d158 into fikovnik:release/1.6.1 Jun 19, 2014
@fikovnik fikovnik added this to the 1.6.1 milestone Jun 19, 2014
@fikovnik
Copy link
Owner

Thanks a lot! I merged it in however I found a problem (actually reported by @kojiishi). The thing is that the localization duplicated all XIB files and thus it would require to sync multiple XIBs. This would resulted in a quite a bit of an overhead. I updated the localization to use base i18n. The idea is to have one XIB and then use .strings file for the localization.
The 07fbdb3 commit contains these changes. Please have a look at it and check if it works or not. Thanks!

@hkurosawa
Copy link
Contributor Author

Thank you, I think the base i18n method would be better!

I've checked the commit and found some problem.

  1. PreferencesWindow needs to "Builds for Project Deployment Target(10.8)" for PreferencesWindow.strings to take effect - I'm not sure if it's ok to change the build setting.
  2. PreferencesWindow.xib(Base) needs more space -- I had modified the japanese xib layout to fit with Japanese string width which is xib at b4befb6 .

Thanks!

@hkurosawa
Copy link
Contributor Author

just made a pull request for these issues at #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants