Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved fixes for XIB regressions from discussions in #132 to a separate pull request so that you could review diffs easier on the github site.
During enabling localizations and merging the patch to release/1.6.1 branch, some hunks are likely to be accidentally included and looks errors to me.
This is a pull request to fix all regressions introduced by the merge.
Diff Examinations
The original diff that includes possible errors is unfortunately a bit hard to view because the XIB was moved and duplicated in the same commit, and git does not show diff of the XIB file in two revisions clearly.
To look at the diff, 4e1eef3 reverts all the changes made to base XIB file. And then following commits in this pull request re-apply hunks that look reasonable to me. By looking at changed files of this pull request, you're seeing these (revert and re-apply) patches combined.
If you prefer text rather than diff, here's a summary:
<deployment defaultVersion>
was changed from1070
to1080
. This is probably ok as I can see project targets 10.8 now.showMenuIcon
outlet was removed. This is probably an error, I reverted in this patch.metafont="system"
was changed toLucidaGrande
. This is probably an error, reverted.<buttonCell key="prototype">
were removed. I can't find documents on this element, but by guessing from name, it's a prototype for its child elements. Maybe newer Xcode removes it automatically, but reverted anyway since the removal doesn't look intentional nor meaningful.imageScaling
was changed fromproportionallyDown
toproportionallyUpOrDown
. Not a bad change if Apple is going to release x4 Retina ;-)showMenuBarIconAction:
inShow Icon In Menu Bar
was removed. This is probably an error, reverted.widthSizable="YES" heightSizable="YES"
were added inautoresizingMask
element. This looks like a good change as Apple recommends more auto-sizing and auto-layout.numberFormatter
were changed to hard-code properties such asdecimalSeparator="."
. I suppose this is accidental, and is probably a non-welcoming change since using "." as a decimal separator isn't good for some European languages.