Add 10.8 fallback conditions (Issue #166) #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AXAPIEnabled method was deprecated in OS X 10.9 (Mavericks). However, it is necessary here so it can check if the accessibility settings in OS X 10.8 (Mountain Lion) are enabled. Otherwise, it would keep asking the user to enable them even when they are enabled.
Running the app on OS X 10.8 had it showing the japanese text because it didn't consider English and Base to be the same but it found japanese text before running out of prefered languages. By adding an en.lproj and its respective references the app would run the right localization text for english and japanese.
fikovnik
added a commit
that referenced
this pull request
May 4, 2015
Add 10.8 fallback conditions (Issue #166)
|
Thanks a lot @Gunga ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the necessary files and code for localized messages to show as expected on OS X 10.8. Also included the conditional that checks if the assistive devices have access only when running OS X 10.8 or lower.