Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some great new features for ultra wide monitors #311

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

allanragec
Copy link
Collaborator

Add some great new features for ultra wide monitors:

Divided by 6

Screen Shot 2020-06-04 at 23 43 59

  • Left Third Top
  • Left Third Bottom
  • Center Third Top
  • Center Third Bottom
  • Right Third Top
  • Right Third Bottom

Divided by 3

Screen Shot 2020-06-04 at 23 43 21

  • Left Third
  • Center Third
  • Right Third

Jun-04-2020 23-34-46

@fikovnik
Copy link
Owner

fikovnik commented Jun 5, 2020

Thanks a lot! I don't know if you have seen #296, but I no longer use OSX so I cannot even test this. If you want I could add you to the project if you would like to take over.

@allanragec
Copy link
Collaborator Author

@fikovnik Yeah, I saw that, I sorry about it. I'm using ShiftIt app for a long time and I can't imagine myself without this app. Instead to pay for other apps to have these features, I preferred to send this PR to have it and I'm loving to use these new features in my local machine. Would be a honor to be a maintainer :D

@sposmen
Copy link

sposmen commented Jun 5, 2020

@fikovnik would be great a new maintainer like @allanragec ... I also use it in the MacOS 10.15.x versions and this new feature would be awesome too in my 43" monitor. 🙏🏻

@fikovnik
Copy link
Owner

fikovnik commented Jun 8, 2020

Indeed it would! I have just sent @allanragec an invite to the repo! Thanks a lot!

@allanragec
Copy link
Collaborator Author

@fikovnik do you think it is ready to merge it ? or can we wait a bit more for @rca review

@fikovnik
Copy link
Owner

fikovnik commented Jun 10, 2020 via email

@rca
Copy link
Collaborator

rca commented Jun 10, 2020

From the screenshot, this looks great; I can make use of this myself.

I took a very cursory look at the code, but am curious whether the new locations have keyboard shortcuts as well?

@allanragec
Copy link
Collaborator Author

@rca the default locations are:
image

Copy link
Collaborator

@rca rca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@allanragec allanragec merged commit 4f488b9 into fikovnik:master Jun 11, 2020
@hbto
Copy link

hbto commented Jun 19, 2020

@allanragec awesome work

@gsingh93
Copy link

Can a new release be created which includes this PR?

@JaKXz
Copy link

JaKXz commented Dec 22, 2020

@allanragec or @rca sorry to ping out of the blue on a closed PR, but yeah would love to see a new version published with this cool stuff! :)

@Antiavanti
Copy link

@allanragec sorry to ping out of the blue on a closed PR, but yeah would love to see a new version published with this cool stuff! :)

@allanragec I came here to put the same question, could you create a new release 1.6.7 from current master? I think this PR is definitely worth to be released as soon as possible, because since last release from 2018 this one is a game changer, no doubts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants