Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update retrieval section with Lassie #1812
update retrieval section with Lassie #1812
Changes from all commits
69f845c
46d5953
bc94cfa
6869ce3
a82f3a2
54a4a25
30b1600
442befe
2a269a9
393d9ae
0975dc5
7c4c7ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit of an odd statement right after "Lassie makes Filecoin retrieval easy"... oy maybe we need to just add car extraction directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy of use is not just about 1 line CLI here. I am pointing out that we have come a long way from early models of looking up content then trying to figure how how to dial SPs etc. Once we add car extraction to Lassie, I will update the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps note about where to download and install go-car?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already there at https://github.com/filecoin-project/filecoin-docs/pull/1812/files#diff-392c257e64c55c339f84cd9e5759891b48359815e5fd0fbf55bbefeb6c025e19R53 This is a subsection and we are already installing binaries in the beginning of this section.