Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CID lists #217

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Remove CID lists #217

merged 2 commits into from
Jun 8, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jun 3, 2021

Supersedes #216
Fixes #178
Fixes immediate bottleneck in #166 (but there is another bottleneck)

TODO:

@dirkmc dirkmc force-pushed the refactor/remove-cid-lists branch from 717d450 to 9efa69a Compare June 4, 2021 14:23
Copy link
Collaborator

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirkmc Some comments.

cidsets/cidsets.go Show resolved Hide resolved
cidsets/cidsets.go Outdated Show resolved Hide resolved
cidsets/cidsets_test.go Show resolved Hide resolved
@dirkmc dirkmc merged commit 7e93538 into master Jun 8, 2021
@dirkmc dirkmc deleted the refactor/remove-cid-lists branch June 8, 2021 13:32
@dirkmc dirkmc mentioned this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IO races on received CIDs feature on receiving side
2 participants