Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel transfers between same two peers #254

Merged
merged 4 commits into from
Sep 7, 2021

Conversation

hannahhoward
Copy link
Collaborator

@hannahhoward hannahhoward commented Sep 3, 2021

Goals

HAT TIP @tchardin !!! You may have caught a fairly critical bug.

Your bug report and submitted test revealed a serious issue in the go-graphsync responder implementation.

Implementation

This PR contains some fixes to @tchardin 's test to insure it properly catches the issue in question, and then an update to go-graphsync (ipfs/go-graphsync#211) that fixes the issue.

tchardin and others added 3 commits September 3, 2021 12:32
Update the parallel transfer test to fix the issues that made the test ineffective and then update
go-graphsync to fix the actual issue
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @tchardin 🙌

@codecov-commenter
Copy link

Codecov Report

Merging #254 (04d92bf) into master (7870236) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage   68.00%   67.93%   -0.07%     
==========================================
  Files          24       24              
  Lines        3069     3069              
==========================================
- Hits         2087     2085       -2     
- Misses        627      629       +2     
  Partials      355      355              
Impacted Files Coverage Δ
impl/receiver.go 66.66% <0.00%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7870236...04d92bf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants