remove libp2p protocol cache #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
refactor/remove-proto-cache
branch
from
37522d1
to
ea61d80
Compare
dirkmc
force-pushed
the
refactor/remove-proto-cache
branch
from
ea61d80
to
cd4edc8
Compare
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 67.83% 67.80% -0.03%
==========================================
Files 24 24
Lines 3146 3134 -12
==========================================
- Hits 2134 2125 -9
+ Misses 652 649 -3
Partials 360 360
Continue to review full report at Codecov.
|
Merged
| func (impl *libp2pDataTransferNetwork) Disconnected(n network.Network, conn network.Conn) { | ||
| impl.clearPeerProtocol(conn.RemotePeer()) | ||
| // Keep a string version of the protocols for performance reasons | ||
| impl.dtProtocolStrings = make([]string, 0, len(impl.dtProtocols)) |
There was a problem hiding this comment.
@dirkmc Why do we need this now ?
There was a problem hiding this comment.
Because FirstSupportedProtocol(id, protos...) takes an array of strings (not an array of protocol.ID)
This was referenced Oct 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libp2p has its own protocol cache, so there's no need to keep on external to libp2p