Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richer README #53

Closed
6 tasks done
juliangruber opened this issue Feb 21, 2023 · 4 comments
Closed
6 tasks done

Richer README #53

juliangruber opened this issue Feb 21, 2023 · 4 comments
Assignees
Labels
feature New feature or request

Comments

@juliangruber
Copy link
Member

juliangruber commented Feb 21, 2023

The goals of the README should be (imo):

  1. Elevator pitch of the project docs: add elevator pitch #59
  2. How to run a rudimentary example docs: add high-level example. #53 #54
  3. How to create a basic module docs: add high-level example. #53 #54
  4. How to contribute (either through code, or telling us use cases) docs: add contributing. #53 #55
  5. High level project roadmap docs: add contributing. #53 #55
@juliangruber juliangruber added the feature New feature or request label Feb 21, 2023
@juliangruber juliangruber self-assigned this Feb 21, 2023
@juliangruber
Copy link
Member Author

Via @bajtos:

juliangruber added a commit that referenced this issue Feb 21, 2023
@juliangruber
Copy link
Member Author

How to create a basic module

@bajtos are we ready to talk about zinnia "modules" yet? Is a module simply a js file with 0-n files it imports from?

juliangruber added a commit that referenced this issue Feb 21, 2023
@bajtos
Copy link
Member

bajtos commented Feb 22, 2023

How to create a basic module

@bajtos are we ready to talk about zinnia "modules" yet? Is a module simply a js file with 0-n files it imports from?

Yes, I think we are ready.

We don't support module imports yet (see #43), so right now a module is simply a single JS file that implements a long-running process.

I know the missing support for ES Module imports is a poor DX; I'd like to fix it soon after the first public alpha. I propose mentioning #43 in the text explaining that a module must be a single file.

juliangruber added a commit that referenced this issue Feb 23, 2023
* docs: add contributing. #53

* mention ADRs

* npx prettier -w .

* prettier ignore runtime/vendored

* revert prettier

---------

Co-authored-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos added a commit that referenced this issue Feb 23, 2023
Co-authored-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
Copy link
Member

bajtos commented Feb 27, 2023

Closing as done. Please reopen if you disagree, @juliangruber

@bajtos bajtos closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants