Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upload release binaries to GH Release #90

Merged
merged 10 commits into from
Mar 6, 2023
Merged

ci: upload release binaries to GH Release #90

merged 10 commits into from
Mar 6, 2023

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Mar 6, 2023 •
edited
Loading

  • Before this change, we were attaching the uploaded binaries to the workflow run. This PR changes the workflow to attach the binaries to a GH Release.
  • Disable LTO on Windows in an attempt to fix the failing release build
  • Rename release binaries
  • Disable incremental release builds

See #23

bajtos added 10 commits March 6, 2023 12:56
@bajtos
ci: upload release binaries to GH Release
65dcc0e 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
build: disable LTO on Windows
0c93e77 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
ci: remove Rust cache from Release workflow
873cebd 
Caches are not shared between different tags. We never get a cache hit.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
build: another fix for Windows release builds
4c169d8 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
ci: create a new release as a draft
fe1ba7e 
Switch to `softprops/action-gh-release` and enable `draft` option.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
ci: rename release binaries
9fbc9f4 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
fixup! fix warning about unsupported option
23ab3f1 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
revert 4c169d8
9ac6d97 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
build: disable incremental release builds
f154d75 
We are not able to cache build artifacts between CI/CD builds.
Disabling incremental builds can actually make the builds faster,
as there is no need to create additional artifacts for incremental
rebuilds.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
ci: fail the release build on missing artifacts
ac76bd2 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos merged commit 508cdd1 into main Mar 6, 2023
@bajtos bajtos deleted the ci-upload-to-release branch March 6, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bajtos