Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHPUnit 6 #553

Closed
wants to merge 1 commit into from
Closed

Support PHPUnit 6 #553

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link
Contributor

No description provided.

@denis-sokolov
Copy link
Collaborator

It’s good to ugprade, but we don’t need three different versions of PHPUnit. It is my understanding, we have two to support PHP 5.5 and PHP 7. If you upgrade to PHPUnit 6, perhaps we can drop PHPUnit 5?

@carusogabriel
Copy link
Contributor Author

Yes, we can have:

  • PHPUnit 4 for PHP versions 5.5 and 5.6;
  • PHPUnit 6 for PHP versions 7.0, 7.1 and 7.2.

What do you think?

@denis-sokolov
Copy link
Collaborator

I support this fully!

@carusogabriel
Copy link
Contributor Author

Something is wrong with PHP 5.6 tests. Gonna search.

@carusogabriel
Copy link
Contributor Author

@denis-sokolov After remove PHPUnit 5 the tests fail. Should we keep it?

@pascalheidmann pascalheidmann mentioned this pull request Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carusogabriel @denis-sokolov