Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence Component: expose input files bytes size for Snowflake BulkLoad #2932

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

agarwali
Copy link

@agarwali agarwali commented Jun 26, 2024

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Added the support to return input files bytes metrics for Snowflake during bulk load in IngestorResult

Which issue(s) this PR fixes:

Other notes for reviewers:

Change proposed by @prasar-ashutosh

Does this PR introduce a user-facing change?

Only impacts users of legend-engine-xts-persistence-component

@agarwali agarwali requested a review from a team as a code owner June 26, 2024 01:56
Copy link

linux-foundation-easycla bot commented Jun 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@agarwali agarwali changed the title Persist query Id and query operator stats for Snowflake Sink bulkload Persistence Component: expose input files bytes size for Snowflake BulkLoad Jul 3, 2024
@agarwali agarwali closed this Jul 10, 2024
@agarwali agarwali reopened this Jul 10, 2024
epsstan
epsstan previously approved these changes Aug 6, 2024
@finos-admin
Copy link
Member

This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

@agarwali
Copy link
Author

agarwali commented Sep 10, 2024

activating the pull request

@finos-admin finos-admin removed the Stale label Sep 10, 2024
# Conflicts:
#	legend-engine-xts-persistence/legend-engine-xt-persistence-component/legend-engine-xt-persistence-component-relational-core/src/main/java/org/finos/legend/engine/persistence/components/relational/api/ApiUtils.java
#	legend-engine-xts-persistence/legend-engine-xt-persistence-component/legend-engine-xt-persistence-component-relational-core/src/main/java/org/finos/legend/engine/persistence/components/relational/api/RelationalIngestorAbstract.java
#	legend-engine-xts-persistence/legend-engine-xt-persistence-component/legend-engine-xt-persistence-component-relational-core/src/main/java/org/finos/legend/engine/persistence/components/relational/api/RelationalLockProviderAbstract.java
#	legend-engine-xts-persistence/legend-engine-xt-persistence-component/legend-engine-xt-persistence-component-relational-core/src/main/java/org/finos/legend/engine/persistence/components/relational/api/RelationalSchemaEvolutionServiceAbstract.java
#	legend-engine-xts-persistence/legend-engine-xt-persistence-component/legend-engine-xt-persistence-component-relational-core/src/main/java/org/finos/legend/engine/persistence/components/relational/jdbc/JdbcHelper.java
Copy link

Test Results

  1 035 files  +2    1 035 suites  +2   1h 25m 21s ⏱️ - 3m 15s
12 228 tests +9  12 138 ✔️ +9  90 💤 ±0  0 ±0 
17 781 runs  +9  17 691 ✔️ +9  90 💤 ±0  0 ±0 

Results for commit 0105a61. ± Comparison against base commit 027c1ae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants