-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dataspace analytics result to contain executable info #3080
update dataspace analytics result to contain executable info #3080
Conversation
b32c8c2
to
df1ac3c
Compare
0eb5617
to
765e3dc
Compare
765e3dc
to
9e606fa
Compare
5e3295b
to
546fe70
Compare
I think we are in the right direction, but we need to be mindful of not restoring the same exact information. We should store only things we need. I think we can keep the template info inside execution context based on your filtering. But for functions, it should be stored globally in the DataSpaceAnalysisResult class. Furthermore, one thing I would like you to improve (separate PR is fine). |
aab5385
to
9e43396
Compare
For moving |
9e43396
to
a9cf53f
Compare
a73fe9c
to
3627076
Compare
...java/org/finos/legend/engine/generation/analytics/model/DataSpaceExecutableAnalysisInfo.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/org/finos/legend/engine/generation/analytics/DataSpaceAnalyticsHelper.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/org/finos/legend/engine/generation/analytics/DataSpaceAnalyticsHelper.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/org/finos/legend/engine/generation/analytics/DataSpaceAnalyticsHelper.java
Outdated
Show resolved
Hide resolved
legend-engine-config/legend-engine-extensions-collection-generation/pom.xml
Show resolved
Hide resolved
...ion/src/main/java/org/finos/legend/engine/generation/analytics/DataSpaceAnalyticsHelper.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/org/finos/legend/engine/generation/analytics/DataSpaceAnalyticsHelper.java
Outdated
Show resolved
Hide resolved
...java/org/finos/legend/engine/generation/analytics/model/DataSpaceExecutableAnalysisInfo.java
Outdated
Show resolved
Hide resolved
...java/org/finos/legend/engine/generation/analytics/model/DataSpaceExecutableAnalysisInfo.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/org/finos/legend/engine/generation/analytics/DataSpaceAnalyticsHelper.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/org/finos/legend/engine/generation/analytics/DataSpaceAnalyticsHelper.java
Outdated
Show resolved
Hide resolved
14443f6
to
72b9b92
Compare
72b9b92
to
5b741e5
Compare
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
update dataspace analytics result to contain function info and executable info
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?