Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence Component: Fix schema evolution for bitemp temp tables #3090

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

kumuwu
Copy link
Contributor

@kumuwu kumuwu commented Sep 16, 2024

What type of PR is this?

  • Bug Fix

What does this PR do / why is it needed ?

Schema evolution was not working for bitemporal delta (source specifies from only), as temp tables got created with old schema. Fixed by correcting the sequence of SQL generation (schema evolution first).

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

@kumuwu kumuwu requested a review from a team as a code owner September 16, 2024 05:53
Copy link

Test Results

  1 033 files  ±0    1 033 suites  ±0   1h 27m 0s ⏱️ + 1m 28s
12 261 tests +3  12 171 ✔️ +3  90 💤 ±0  0 ±0 
17 940 runs  +3  17 850 ✔️ +3  90 💤 ±0  0 ±0 

Results for commit a0ed9c6. ± Comparison against base commit 8ddd43b.

Copy link
Contributor

@prasar-ashutosh prasar-ashutosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@gs-ssh16 gs-ssh16 merged commit 11e1801 into finos:master Sep 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants