Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replay protection feature #641

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

agbaraka
Copy link

@agbaraka agbaraka commented Sep 8, 2024

Hello Team.

Kindly assist to review this initial implementation of App Check Replay Protection API as requested in issue #632

Your feedback and guidance will be highly appreciated.

Copy link

google-cla bot commented Sep 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@weixifan weixifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! I have left comments addressing App Check domain-specific concerns, but I will leave it to other reviewers to address Go language style and library use concerns.

appcheck/appcheck.go Outdated Show resolved Hide resolved
appcheck/appcheck.go Outdated Show resolved Hide resolved
appcheck/appcheck.go Outdated Show resolved Hide resolved
appcheck/appcheck.go Outdated Show resolved Hide resolved
appcheck/appcheck_test.go Outdated Show resolved Hide resolved
appcheck/appcheck_test.go Outdated Show resolved Hide resolved
@agbaraka
Copy link
Author

Hi @weixifan and @lahirumaramba

Thank you for taking your time to review this implementation. Your guidance on this is much appreciated.

I have update the implementation as per @weixifan recommendations. Please review and advise.

Happy coding

appcheck/appcheck.go Outdated Show resolved Hide resolved
@agbaraka
Copy link
Author

Hi @weixifan. I hope all is well.

I have refactor token verifier url generation as recommended. I agree, It looks cleaner than before.

Please review

Thanks

@agbaraka
Copy link
Author

Hi @weixifan and @lahirumaramba.

Any feedback on this PR?

Copy link

@weixifan weixifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay. This is approved from App Check's point of view. A Golang reviewer will review your PR for style and consistency with existing code.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants