Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use optional chaining in FirebaseError #2581

Merged
merged 2 commits into from
May 29, 2024
Merged

fix: Use optional chaining in FirebaseError #2581

merged 2 commits into from
May 29, 2024

Conversation

lahirumaramba
Copy link
Member

Fixes: #2571

@lahirumaramba lahirumaramba mentioned this pull request May 28, 2024
Closed
jonathanedey
jonathanedey approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nushio
Copy link

Nushio commented May 28, 2024

Thanks for the quick turnaround on this. It fixes the test issues in our project!

@jbaldassari
Copy link

Confirmed this fixes my project as well

@lahirumaramba
Copy link
Member Author

@Nushio @jbaldassari Thanks for confirming the fix!

@lahirumaramba lahirumaramba merged commit 2efcec9 into master May 29, 2024
10 checks passed
@lahirumaramba lahirumaramba deleted the lm-fix-errorts branch May 29, 2024 18:20
This was referenced Jul 11, 2024
Merged
Merged
@kenn7575 kenn7575 mentioned this pull request Jul 11, 2024
Merged
@Arjun31415 Arjun31415 mentioned this pull request Jul 12, 2024
Merged
@FarrelBhagaskara FarrelBhagaskara mentioned this pull request Jul 12, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Jul 12, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jul 12, 2024
Open
@KDONJS KDONJS mentioned this pull request Jul 12, 2024
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Jul 13, 2024
Open
This was referenced Jul 13, 2024
Open
Open
@aravindvnair99 aravindvnair99 mentioned this pull request Jul 15, 2024
Closed
This was referenced Jul 15, 2024
Open
Open
@saileshbro saileshbro mentioned this pull request Jul 16, 2024
Merged
This was referenced Jul 17, 2024
Open
Open
@WontonSam WontonSam mentioned this pull request Jul 18, 2024
Open
@aravindvnair99 aravindvnair99 mentioned this pull request Aug 28, 2024
Open
This was referenced Aug 30, 2024
Open
Open
Open
Open
Open
Open
Open
@Erenkrs Erenkrs mentioned this pull request Sep 7, 2024
Open
@tweiss9 tweiss9 mentioned this pull request Sep 7, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 8, 2024
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Sep 8, 2024
Open
@Ocor17 Ocor17 mentioned this pull request Sep 9, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 9, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 9, 2024
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Sep 10, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 11, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Sep 13, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Sep 13, 2024
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Sep 13, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 13, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 14, 2024
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Sep 14, 2024
Open
This was referenced Sep 15, 2024
Open
Open
Open
@IvanCastroDev IvanCastroDev mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanedey jonathanedey jonathanedey approved these changes

Assignees

@jonathanedey jonathanedey

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firebase Admin 12.1.1 issue with error.ts
4 participants
@lahirumaramba @Nushio @jbaldassari @jonathanedey