Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CONTRIBUTING.md #13179

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

totoro642
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).

I read it ;) and found a typo in it !

  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

@paulb777
Copy link
Member

Thanks!

@paulb777 paulb777 merged commit 13043e7 into firebase:main Jun 25, 2024
32 checks passed
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Jul 9, 2024
….29.0" (#1153)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://github.com/firebase/firebase-ios-sdk)
| minor | `from: "10.28.1"` -> `from: "10.29.0"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.29.0`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.29.0):
Firebase Apple 10.29.0

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.28.1...10.29.0)

The Firebase Apple SDK (10.29.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.29.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- \[Messaging] Rename initWithFileName internal method by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#13139
- Revert "Add SIGTERM support
([#&#8203;12881](https://github.com/firebase/firebase-ios-sdk/issues/12881))"
by [@&#8203;themiswang](https://github.com/themiswang) in
[firebase/firebase-ios-sdk#13162
- \[MLModelDownloader] Use `FirebaseLogger` instead of
`GULLoggerWrapper` by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[firebase/firebase-ios-sdk#13160
- \[Messaging] Fix APS Environment entitlement key on visionOS by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[firebase/firebase-ios-sdk#13176
- \[Messaging] Update `TARGET_OS_*` conditionals by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[firebase/firebase-ios-sdk#13184
- VertexAI: use shared repository for test golden files by
[@&#8203;tanzimfh](https://github.com/tanzimfh) in
[firebase/firebase-ios-sdk#13186
- Update FPRDataUtils.m by
[@&#8203;Kyle-Ye](https://github.com/Kyle-Ye) in
[firebase/firebase-ios-sdk#13200
- \[Vertex AI] Add support for compiling on watchOS by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[firebase/firebase-ios-sdk#13215

#### New Contributors

- [@&#8203;tanzimfh](https://github.com/tanzimfh) made their first
contribution in
[firebase/firebase-ios-sdk#13152
- [@&#8203;totoro642](https://github.com/totoro642) made their first
contribution in
[firebase/firebase-ios-sdk#13179
- [@&#8203;Kyle-Ye](https://github.com/Kyle-Ye) made their first
contribution in
[firebase/firebase-ios-sdk#13200

**Full Changelog**:
firebase/firebase-ios-sdk@10.28.1...10.29.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants