Updated tests

firebase · Sep 19, 2024 · da31e42 · da31e42
1 parent 00f86c0
commit da31e42
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 8 deletions.
diff --git a/packages/data-connect/src/network/fetch.ts b/packages/data-connect/src/network/fetch.ts
@@ -49,7 +49,7 @@ export function dcFetch<T, U>(
   if (accessToken) {
     headers['X-Firebase-Auth-Token'] = accessToken;
   }
-  if(appId) {
+  if (appId) {
     headers['x-firebase-gmpid'] = appId;
   }
   if (appCheckToken) {

diff --git a/packages/data-connect/test/unit/fetch.test.ts b/packages/data-connect/test/unit/fetch.test.ts
@@ -40,7 +40,15 @@ describe('fetch', () => {
       message
     });
     await expect(
-      dcFetch('http://localhost', {}, {} as AbortController, null, null, null, false)
+      dcFetch(
+        'http://localhost',
+        {},
+        {} as AbortController,
+        null,
+        null,
+        null,
+        false
+      )
     ).to.eventually.be.rejectedWith(message);
   });
   it('should throw a stringified message when the server responds with an error without a message property in the body', async () => {
@@ -51,7 +59,15 @@ describe('fetch', () => {
     };
     mockFetch(json);
     await expect(
-      dcFetch('http://localhost', {}, {} as AbortController, null, null, null, false)
+      dcFetch(
+        'http://localhost',
+        {},
+        {} as AbortController,
+        null,
+        null,
+        null,
+        false
+      )
     ).to.eventually.be.rejectedWith(JSON.stringify(json));
   });
 });
diff --git a/packages/data-connect/test/unit/gmpid.test.ts b/packages/data-connect/test/unit/gmpid.test.ts
@@ -39,10 +39,10 @@ const fakeFetchImpl = sinon.stub().returns(
 describe('GMPID Tests', () => {
   let dc: DataConnect;
   let app: FirebaseApp;
-  let APPID = 'MYAPPID';
+  const APPID = 'MYAPPID';
   beforeEach(() => {
     initializeFetch(fakeFetchImpl);
-    app = initializeApp({ projectId: 'p',appId: APPID }, 'fdsasdf'); // TODO(mtewani): Replace with util function
+    app = initializeApp({ projectId: 'p', appId: APPID }, 'fdsasdf'); // TODO(mtewani): Replace with util function
     dc = getDataConnect(app, { connector: 'c', location: 'l', service: 's' });
   });
   afterEach(async () => {
@@ -63,7 +63,11 @@ describe('GMPID Tests', () => {
   });
   it('should send a request with no gmpid if using the app id is not specified', async () => {
     const app2 = initializeApp({ projectId: 'p' }, 'def'); // TODO(mtewani): Replace with util function
-    const dc2 = getDataConnect(app2, { connector: 'c', location: 'l', service: 's' });
+    const dc2 = getDataConnect(app2, {
+      connector: 'c',
+      location: 'l',
+      service: 's'
+    });
     // @ts-ignore
     await executeQuery(queryRef(dc2, '')).catch(() => {});
     expect(fakeFetchImpl).to.be.calledWithMatch(
@@ -74,7 +78,7 @@ describe('GMPID Tests', () => {
         }
       }
     );
-    dc2._delete();
-    deleteApp(app2);
+    await dc2._delete();
+    await deleteApp(app2);
   });
 });