[auth] Retry IndexedDB errors a fixed number of times #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0b73fbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There appears to be an issue with webkit where it periodically closes the connections such as when the tab is backgrounded (https://bugs.webkit.org/show_bug.cgi?id=197050). We can't repro, but Firestore did something similar and have stopped getting error reports.
avolkovi
force-pushed
the
avolkovi/indexeddb
branch
from
4af42f4
to
0b73fbf
Compare
Feiyang1
approved these changes
Nov 12, 2020
| self.getTransaction_(dbTemp, true)); | ||
| let isLocked = false; | ||
| return this | ||
| .withRetry_((db) => { |
There was a problem hiding this comment.
Does closure compile it to regular functions? I wasn't sure if you can use arrow functions in closure.
There was a problem hiding this comment.
seems to compile but does the const self = this trick under the hood google/closure-compiler#2853
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be an issue with webkit where it periodically closes the connections such as when the tab is backgrounded (https://bugs.webkit.org/show_bug.cgi?id=197050). We can't repro, but Firestore did something similar and have stopped getting error reports.
Closes #1926