Remove referrerPolicy from Cloudflare Worker fetch requests
#8393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b1f3860 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (126,839 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
DellaBitta
changed the title
referrerPolicy from Cloudflare Worker fetch requests
DellaBitta
requested review from
a team,
lisajian,
Xiaoshouzi-gh and
sam-gc
as code owners
NhienLam
approved these changes
Sep 5, 2024
hsubox76
reviewed
Sep 5, 2024
.changeset/khaki-numbers-nail.md
Outdated
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| '@firebase/auth': minor | |||
There was a problem hiding this comment.
Why a minor for auth? The API doesn't change. I don't think we bump automatically based on dependencies' bump level. I'm not totally sure if changesets does it but I think it also doesn't.
There was a problem hiding this comment.
Ok, switched Auth to a patch bump instead of a minor bump.
Changeset File Check
|
Xiaoshouzi-gh
approved these changes
Sep 6, 2024
| @@ -148,14 +148,19 @@ export async function _performApiRequest<T, V>( | |||
| headers[HttpHeader.X_FIREBASE_LOCALE] = auth.languageCode; | |||
| } | |||
|
|
|||
| const fetchArgs: RequestInit = { | |||
There was a problem hiding this comment.
we should consider adding some unit tests on _performApiRequest since we introduced new logic.
Xiaoshouzi-gh
approved these changes
Sep 9, 2024
packages/auth/src/api/index.test.ts
Outdated
| if (request !== undefined && request.referrerPolicy !== undefined) { | ||
| referrerPolicySet = true; | ||
| } | ||
| return new Promise<never>((_, reject) => |
There was a problem hiding this comment.
optional: possible to resolve the promise instead of reject?
There was a problem hiding this comment.
Also curious why these tests have a rejected promise.
There was a problem hiding this comment.
Done! Updated tests so that these mocks resolve.
hsubox76
approved these changes
Sep 9, 2024
hsubox76
reviewed
Sep 9, 2024
Merged
dlarocque
pushed a commit
that referenced
this pull request
Sep 16, 2024
The Cloudflare Worker runner runtime doesn't support the `fetch` parameter `referrerPolicy` and throws if one is defined. In attempt to better support Cloudlfare, we will remove this parameter from `fetch` requests when we detect the SDK running in a Cloudflare runner enviornment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
The Cloudflare Worker runner runtime doesn't support the
fetchparameterreferrerPolicyand throws if one is defined. In attempt to better support Cloudlfare, we will remove this parameter fromfetchrequests when we detect the SDK is running in a Cloudflare runner environment.Fixes #8355.
Testing
CI. Updated unit tests to test if
referrerPolicyis omitted ifisCloudflareWorker()returns true.API Changes
N/A.