Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge v11 Feature Branch #8475

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Merge v11 Feature Branch #8475

wants to merge 4 commits into from
+211 −203

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Sep 3, 2024 •
edited
Loading

This feature branch is targeted for Oct 1 and is expected to include:

  • Node engines fields set to 18+
  • Remove undici/node-fetch
  • TBD

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7194d9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@firebase/rules-unit-testing Patch
@firebase/firestore-compat Patch
@firebase/functions-compat Patch
@firebase/storage-compat Patch
@firebase/auth-compat Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/storage Patch
@firebase/auth Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 3, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (47b0913)Merge (989809b)Diff
    main179 kB179 kB-74 B (-0.0%)

  • @firebase/auth-compat

    TypeBase (47b0913)Merge (989809b)Diff
    main29.5 kB29.4 kB-74 B (-0.3%)

  • @firebase/auth/internal

    TypeBase (47b0913)Merge (989809b)Diff
    main214 kB214 kB-74 B (-0.0%)

  • @firebase/firestore

    TypeBase (47b0913)Merge (989809b)Diff
    browser381 kB381 kB+33 B (+0.0%)
    esm5366 kB367 kB+38 B (+0.0%)
    main587 kB587 kB+39 B (+0.0%)
    module381 kB381 kB+33 B (+0.0%)
    react-native381 kB381 kB+33 B (+0.0%)

  • @firebase/firestore-lite

    TypeBase (47b0913)Merge (989809b)Diff
    browser111 kB111 kB-56 B (-0.1%)
    esm5108 kB108 kB-25 B (-0.0%)
    main153 kB153 kB-156 B (-0.1%)
    module111 kB111 kB-56 B (-0.1%)
    react-native111 kB111 kB-56 B (-0.1%)

  • @firebase/functions

    TypeBase (47b0913)Merge (989809b)Diff
    browser9.76 kB9.65 kB-113 B (-1.2%)
    esm512.1 kB12.0 kB-113 B (-0.9%)
    main12.8 kB12.6 kB-163 B (-1.3%)
    module9.76 kB9.65 kB-113 B (-1.2%)

  • @firebase/rules-unit-testing

    TypeBase (47b0913)Merge (989809b)Diff
    main17.8 kB17.6 kB-228 B (-1.3%)

  • @firebase/storage

    TypeBase (47b0913)Merge (989809b)Diff
    main59.4 kB59.3 kB-90 B (-0.2%)

  • bundle

    15 size changes

    TypeBase (47b0913)Merge (989809b)Diff
    firestore (CSI Auto Indexing Disable and Delete)269 kB272 kB+2.50 kB (+0.9%)
    firestore (CSI Auto Indexing Enable)269 kB272 kB+2.50 kB (+0.9%)
    firestore (Query Cursors)242 kB249 kB+6.18 kB (+2.6%)
    firestore (Query)240 kB246 kB+6.18 kB (+2.6%)
    firestore (Read data once)228 kB234 kB+6.18 kB (+2.7%)
    firestore (Read Write w Persistence)325 kB328 kB+2.50 kB (+0.8%)
    firestore (Realtime updates)230 kB236 kB+6.18 kB (+2.7%)
    firestore (Transaction)207 kB214 kB+6.45 kB (+3.1%)
    firestore (Write data)207 kB213 kB+6.18 kB (+3.0%)
    firestore-lite (Query Cursors)91.4 kB91.4 kB-56 B (-0.1%)
    firestore-lite (Query)87.6 kB87.5 kB-56 B (-0.1%)
    firestore-lite (Read data once)63.1 kB63.0 kB-53 B (-0.1%)
    firestore-lite (Transaction)88.3 kB88.2 kB-56 B (-0.1%)
    firestore-lite (Write data)72.6 kB72.6 kB-56 B (-0.1%)
    functions (call)32.0 kB31.9 kB-49 B (-0.2%)

  • firebase

    TypeBase (47b0913)Merge (989809b)Diff
    firebase-compat.js788 kB791 kB+2.40 kB (+0.3%)
    firebase-firestore-compat.js344 kB346 kB+2.45 kB (+0.7%)
    firebase-firestore-lite.js119 kB119 kB-56 B (-0.0%)
    firebase-firestore.js440 kB440 kB+33 B (+0.0%)
    firebase-functions-compat.js8.22 kB8.17 kB-52 B (-0.6%)
    firebase-functions.js12.0 kB11.9 kB-49 B (-0.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GmeBneGmN3.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 3, 2024 •
edited
Loading

Size Analysis Report 1

This report is too large (462,482 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IuctEmyFBo.html

wu-hui and others added 3 commits September 9, 2024 18:10
@wu-hui
Make memory lru gc the default (#8110)
a377fb2 
* Make memory lru gc the default

* undo yarn.lock

* Make memory lru gc the default

* Fix tests
@DellaBitta
V11 release removal of node-fetch and undici dependencies (#8492)
c8937e7 
Our v11 release will require node 18+. Since fetch has been introduced in these node versions, we can remove our dependency on third party fetch implementations.

This change removes our usage of fetch variants undici and node-fetch for our node target builds and our CI tools.
@hsubox76
Merge branch 'main' into v11
7194d9c
@github-actions GitHub Actions
Copy link
Contributor

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:%0A - @firebase/app-check-compat%0A - @firebase/app-check%0A - @firebase/app-compat%0A - @firebase/app%0A - @firebase/component%0A - @firebase/database-compat%0A - @firebase/database%0A - @firebase/logger%0A - @firebase/util%0A%0A Make sure this was intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi will be requested when the pull request is marked ready for review avolkovi is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc will be requested when the pull request is marked ready for review sam-gc is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi will be requested when the pull request is marked ready for review yuchenshi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian will be requested when the pull request is marked ready for review lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh will be requested when the pull request is marked ready for review Xiaoshouzi-gh is a code owner

@zwu52 zwu52 Awaiting requested review from zwu52 zwu52 will be requested when the pull request is marked ready for review zwu52 is a code owner

@maneesht maneesht Awaiting requested review from maneesht maneesht will be requested when the pull request is marked ready for review maneesht is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang will be requested when the pull request is marked ready for review tonyjhuang is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g will be requested when the pull request is marked ready for review aashishpatil-g is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubox76 @google-oss-bot @wu-hui @DellaBitta