Rollup JS files with rollup-typescript-plugin #8503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dlarocque
force-pushed
the
dl/rollup-allowjs
branch
from
a520ce5
to
eed8644
Compare
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (a377fb2) and merge commit (0ccfec9).Test Logs |
dlarocque
requested review from
a team,
erikeldridge,
jposuna,
avolkovi,
yoyomyo,
lisajian,
Xiaoshouzi-gh,
sam-gc,
zwu52,
maneesht,
tonyjhuang and
aashishpatil-g
as code owners
dlarocque
force-pushed
the
dl/rollup-allowjs
branch
from
eed8644
to
c0115ea
Compare
The rollup-typescript-plugin does not transpile JS files using the TS compiler by default. This means that external dependencies that provide JS bundles will not be transpiled to the target ES version specified in the TypeScript config used by the plugin. This resulted in one of our dependencies (https://github.com/jakearchibald/idb) being included in the CDN bundles without being transpiled to ES5 (the target ES version). Since this dependencies bundle uses ES2018 syntax (object spread operator `{ ...x }`), this upgraded our CDN bundles' minimum ES version requirement to ES2018 which isn't compatible with older browser versions. To see the ES2018 syntax in one of the CDN bundles, see https://www.gstatic.com/firebasejs/10.13.1/firebase-app.js and search for `...oldTraps`.
dlarocque
force-pushed
the
dl/rollup-allowjs
branch
from
c0115ea
to
dc115a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rollup-typescript-plugin does not transpile JS files using the TS compiler by default. This means that external dependencies that provide JS bundles will not be transpiled to the target ES version specified in the TypeScript config used by the plugin.
In other words, if one of our dependencies has a bundle that uses newer JS features that aren't supported in all browsers, it will be included in our bundle without being translated into an older JS version that we promise our bundles are compatible with.
This resulted in one of our dependencies (https://github.com/jakearchibald/idb) being included in the CDN bundles without being transpiled to ES5 (the target ES version). Since this dependencies bundle uses ES2018 syntax (object spread operator
{ ...x }), this upgraded our CDN bundles' minimum ES version requirement to ES2018 which isn't compatible with older browser versions. To see the ES2018 syntax in one of the CDN bundles, see https://www.gstatic.com/firebasejs/10.13.1/firebase-app.js and search for...oldTraps.After enabling
allowJsin the typescript plugin CDN config, this ES2018 code now gets transpiled into ES5 code.I verified the bundle is now es5 compliant by using ESLint Playground.