-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V11 - Remove functions node bundle #8507
Open
DellaBitta
wants to merge
34
commits into
v11
Choose a base branch
from
v11-remove-func-node-bundle
base: v11
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
4bdab6f
Removed node-fetch from rules-unit-testing
DellaBitta 45723bb
Draft emulator impl not quite working.
DellaBitta 5ee8eb7
Wrap the emulator download in a promise
DellaBitta 84f0770
Update yarn.lock
DellaBitta afea52d
emulator.ts reject/resolve fix. formatting.
DellaBitta 79753b2
Update emaultor.ts with chmod operation.
DellaBitta ba32125
emulator.ts remove setBinaryPath & add comments.
DellaBitta 6fdd758
Remove undici from messaging testing
DellaBitta 0601594
Remove undici from auth source and package.json
DellaBitta 2c4a46e
auth format
DellaBitta 3b93ffe
repo-scripts
DellaBitta 97eb7a3
Auth: remove custom webpack step for undici
DellaBitta 9c010b2
Remove undici from firestore
DellaBitta 69d789c
Lint fix.
DellaBitta c8c64e7
Remove fetch from functions
DellaBitta b16903b
fix build
DellaBitta 0c05f70
Fixed build?
DellaBitta 5077ae3
format
DellaBitta 7a6691b
Remove undici from storage
DellaBitta 033c4dc
Remove undici from changelog generator
DellaBitta 9aa1f75
Fix storage test for node
DellaBitta f35d2a0
Remove no longer required eslint-disable comments.
DellaBitta 1e25ff2
Functions export public-types
DellaBitta 7acb14e
Auth - remove superfluous casting.
DellaBitta 498bc7b
Fix hanging promise in emulator download code
DellaBitta 10a6149
Remove fetch casting in auth-compat
DellaBitta 10e089e
Changeset
DellaBitta d517b14
Changeset 2
DellaBitta 399efc0
Remove functions node bundle
DellaBitta 8bb819b
Changeset
DellaBitta 49f0618
Change test:node target file
DellaBitta 3f14414
Update functions-compat
DellaBitta 8cb2f4d
Merge branch 'v11' into v11-remove-func-node-bundle
DellaBitta c055cfe
remove --file src/index.node.ts from functions-compat
DellaBitta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@firebase/functions-compat': patch | ||
'@firebase/functions': patch | ||
--- | ||
|
||
Remove node bundle from the functions SDK as the node-specific fetch code has been removed in favor of using native fetch throughout the SDK. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,16 +3,16 @@ | |
"version": "0.3.12", | ||
"description": "", | ||
"author": "Firebase <firebase-support@google.com> (https://firebase.google.com/)", | ||
"main": "dist/index.node.cjs.js", | ||
"main": "dist/index.cjs.js", | ||
"browser": "dist/index.esm2017.js", | ||
"module": "dist/index.esm2017.js", | ||
"esm5": "dist/index.esm5.js", | ||
"exports": { | ||
".": { | ||
"types": "./dist/src/index.d.ts", | ||
"node": { | ||
"import": "./dist/node-esm/index.node.esm.js", | ||
"require": "./dist/index.node.cjs.js" | ||
"require": "./dist/index.cjs.js", | ||
"import": "./dist/index.esm2017.js" | ||
}, | ||
"esm5": "./dist/index.esm5.js", | ||
"browser": { | ||
|
@@ -57,7 +57,7 @@ | |
"test:all": "run-p --npm-path npm test:browser test:node", | ||
"test:browser": "karma start --single-run", | ||
"test:browser:debug": "karma start --browsers=Chrome --auto-watch", | ||
"test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'src/{,!(browser)/**/}*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js", | ||
"test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'src/{,!(browser)/**/}*.test.ts' --config ../../config/mocharc.node.js", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you also remove the file itself? It's not showing up as removed in the Github diff for me. |
||
"test:emulator": "env FIREBASE_FUNCTIONS_HOST=http://localhost FIREBASE_FUNCTIONS_PORT=5005 run-p --npm-path npm test:node", | ||
"trusted-type-check": "tsec -p tsconfig.json --noEmit", | ||
"add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../functions/dist/functions-public.d.ts -o dist/src/index.d.ts -a -r Functions:types.FirebaseFunctions -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/functions" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like functions-compat also has a src/index.node.ts, and it's also referenced in this file's
test:node
npm script.