Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] move firebase auth calls to ViewModels #1459

Draft
wants to merge 9 commits into
base: compose
Choose a base branch
from

Conversation

thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented Feb 16, 2023

Part of #1457


Some caveats found in the process:

Google Sign in

Ideally, we'd inject the GoogleSignInClient the same way we inject FirebaseAuth into the ViewModel, but some APIs require an Activity, so I've decided to keep GoogleSignInClient on the UI code for now.

@thatfiredev thatfiredev changed the title [WIP] move firebase auth calls to a dedicated ViewModel [WIP] move firebase auth calls to ViewModels Feb 17, 2023
wallyf1972

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants