-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose code for App Distribution #1630
Compose code for App Distribution #1630
Conversation
@b1no0019 thanks for fixing the CLA :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I just have a few suggestions
/* Other default text styles to override | ||
titleLarge = TextStyle( | ||
fontFamily = FontFamily.Default, | ||
fontWeight = FontWeight.Normal, | ||
fontSize = 22.sp, | ||
lineHeight = 28.sp, | ||
letterSpacing = 0.sp | ||
), | ||
labelSmall = TextStyle( | ||
fontFamily = FontFamily.Default, | ||
fontWeight = FontWeight.Medium, | ||
fontSize = 11.sp, | ||
lineHeight = 16.sp, | ||
letterSpacing = 0.5.sp | ||
) | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this comment is created by Android Studio, but I think we can remove it since we won't be overriding any more styles.
/* Other default text styles to override | |
titleLarge = TextStyle( | |
fontFamily = FontFamily.Default, | |
fontWeight = FontWeight.Normal, | |
fontSize = 22.sp, | |
lineHeight = 28.sp, | |
letterSpacing = 0.sp | |
), | |
labelSmall = TextStyle( | |
fontFamily = FontFamily.Default, | |
fontWeight = FontWeight.Medium, | |
fontSize = 11.sp, | |
lineHeight = 16.sp, | |
letterSpacing = 0.5.sp | |
) | |
*/ |
|
||
/* Other default colors to override | ||
background = Color(0xFFFFFBFE), | ||
surface = Color(0xFFFFFBFE), | ||
onPrimary = Color.White, | ||
onSecondary = Color.White, | ||
onTertiary = Color.White, | ||
onBackground = Color(0xFF1C1B1F), | ||
onSurface = Color(0xFF1C1B1F), | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this comment was added by Android Studio, but I think we can remove it.
/* Other default colors to override | |
background = Color(0xFFFFFBFE), | |
surface = Color(0xFFFFFBFE), | |
onPrimary = Color.White, | |
onSecondary = Color.White, | |
onTertiary = Color.White, | |
onBackground = Color(0xFF1C1B1F), | |
onSurface = Color(0xFF1C1B1F), | |
*/ |
Spacer(modifier = Modifier.height(30.dp)) | ||
Image( | ||
painterResource(R.drawable.firebase_lockup_400), | ||
contentDescription = "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a content description to this image?
contentDescription = "", | |
contentDescription = "Firebase logo", |
|
||
// Used to inject this ViewModel's dependencies | ||
// See also: https://developer.android.com/topic/libraries/architecture/viewmodel/viewmodel-factories | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove empty line
Thanks for the review @thatfiredev. All suggestions were applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
EntryChoiceActivity
ComposeMainActivity
AppDistributionViewModel
ComposeMainActivity
inAndroidManifest