Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3.12 support #1141

Merged
merged 11 commits into from
Jan 10, 2024
Merged

Python3.12 support #1141

merged 11 commits into from
Jan 10, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Oct 10, 2023

@jstucke jstucke self-assigned this Oct 10, 2023
@jstucke jstucke force-pushed the python3.12-support branch 2 times, most recently from 3908f90 to 5879f27 Compare October 10, 2023 14:26
ssdeep installation should again work with the latest version of setuptools
version 3.8 of matplotlib cannot be used yet, because it doesn't support Python3.8
and some additional dependencies which got new patches
@jstucke jstucke marked this pull request as ready for review November 22, 2023 13:49
@maringuu
Copy link
Collaborator

If I'm not mistaken the code in src/analysis/plugin/compat.py must be updated after the yara upgrade.
Also the function is definitely missing a unit test.

Copy link
Collaborator

@maringuu maringuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

# for string_instance in string_match.instances:

strings = [(offset, identifier, data.hex()) for offset, identifier, data in match.strings]
# see YARA docs: https://yara.readthedocs.io/en/latest/yarapython.html#yara.StringMatchInstance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary comment?

Copy link
Collaborator Author

@jstucke jstucke Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think it is useful since you can't easily look at the YARA source (because it is a compiled C library)

@maringuu maringuu self-requested a review January 9, 2024 14:38
Copy link
Collaborator

@maringuu maringuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, besides the nit

@jstucke jstucke merged commit 1043432 into master Jan 10, 2024
11 checks passed
@jstucke jstucke deleted the python3.12-support branch January 10, 2024 08:09
@ElDavoo
Copy link

ElDavoo commented Mar 26, 2024

binwalk has not been updated for py3.12 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants