Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support python 3.12 and drop support python 3.9 #447

Merged
merged 12 commits into from
Nov 23, 2023

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Oct 2, 2023

waits for:

This PR adds logprep support for python 3.12 and with this drops support for python 3.9.
Along with this I had to remove semgrep from the project as it seems with the new version they only support the cloud based version of their tool. And as I know, we have no cloud account for the semgrep cloud.
We should search for another SAST tool to check our code in the future.

@ekneg54 ekneg54 self-assigned this Oct 3, 2023
@ekneg54 ekneg54 force-pushed the feature-support-python-3.12 branch 2 times, most recently from 81082bc to abb23f7 Compare November 22, 2023 09:57
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (daff106) 92.04% compared to head (ea28f16) 92.32%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   92.04%   92.32%   +0.28%     
==========================================
  Files         130      130              
  Lines        9257     9478     +221     
==========================================
+ Hits         8521     8751     +230     
+ Misses        736      727       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekneg54 ekneg54 marked this pull request as ready for review November 22, 2023 11:10
@ekneg54 ekneg54 requested review from dtrai2 and ppcad November 22, 2023 11:10
Copy link
Contributor

@dtrai2 dtrai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just found a typo, but besides that it loos good to me!

CHANGELOG.md Outdated Show resolved Hide resolved
versioneer.py Show resolved Hide resolved
@ekneg54 ekneg54 merged commit e085fe1 into main Nov 23, 2023
10 checks passed
@ekneg54 ekneg54 deleted the feature-support-python-3.12 branch April 3, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants