Skip to content

Commit

Permalink
chore!: Remove functions/classes that were scheduled for removal in v…
Browse files Browse the repository at this point in the history
…1.3.0 (#1867)

This functionality should have been deleted before releasing version 1.3.0, but I guess we forgot ;), so better late than never.
  • Loading branch information
st-pasha committed Aug 26, 2022
1 parent b22bc64 commit 00ab347
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 87 deletions.
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ two versions after the current one, such that there will be at least one stable
users get to see the deprecation warning and in the version after that (or a later version) the
deprecated entity should be removed.

Example (if the current version is v1.1.0):
Example (if the current version is v1.3.0):

```dart
@Deprecated('Will be removed in v1.3.0, use nonDeprecatedFeature() instead')
@Deprecated('Will be removed in v1.5.0, use nonDeprecatedFeature() instead')
void deprecatedFeature() {}
```

Expand Down Expand Up @@ -161,7 +161,7 @@ commit message.
## Creating a release

There are a few things to think about when doing a release:

- Search through the codebase for `@Deprecated` methods/fields and remove the ones that are marked
for removal in the version that you are intending to release.
- Create a PR containing the changes for removing the deprecated entities.
Expand All @@ -173,7 +173,7 @@ There are a few things to think about when doing a release:
sure that all the versions are correct.
- Once you are satisfied with the result of the dry run, run `melos publish --no-dry-run`
- Create a PR containing the updated changelog and `pubspec.yaml` files.


[GitHub issue]: https://github.com/flame-engine/flame/issues/new
[GitHub issues]: https://github.com/flame-engine/flame/issues/new
Expand Down
4 changes: 0 additions & 4 deletions packages/flame/lib/assets.dart

This file was deleted.

1 change: 0 additions & 1 deletion packages/flame/lib/game.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export 'src/game/camera/viewport.dart';
export 'src/game/flame_game.dart';
export 'src/game/game.dart';
export 'src/game/game_widget/game_widget.dart';
export 'src/game/mixins/fps_counter.dart';
export 'src/game/mixins/has_draggables.dart';
export 'src/game/mixins/has_hoverables.dart';
export 'src/game/mixins/has_tappables.dart';
Expand Down
5 changes: 0 additions & 5 deletions packages/flame/lib/src/anchor.dart
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ class Anchor {

const Anchor(this.x, this.y);

@Deprecated('Do not use; will be removed in 1.3.0')
Vector2 translate(Vector2 p, Vector2 size) {
return p - (toVector2()..multiply(size));
}

/// Take your position [position] that is on this anchor and give back what
/// that position it would be on in anchor [otherAnchor] with a size of
/// [size].
Expand Down
3 changes: 0 additions & 3 deletions packages/flame/lib/src/components/component_set.dart
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ class ComponentSet extends QueryableOrderedSet<Component> {
strictMode: strictMode ?? defaultStrictMode,
);

@Deprecated('Use ComponentSet.new instead; will be removed in 1.3.0')
ComponentSet.createDefault() : this();

/// Components whose priority changed since the last update.
///
/// When priorities change we need to re-balance the component set, but
Expand Down
8 changes: 0 additions & 8 deletions packages/flame/lib/src/effects/effect.dart
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,6 @@ abstract class Effect extends Component {
/// Optional callback function to be invoked once the effect completes.
void Function()? onComplete;

@Deprecated('It will be removed in v1.3.0. Use Effect.onComplete instead')
void Function()? get onFinishCallback => onComplete;

@Deprecated('It will be removed in v1.3.0. Use Effect.onComplete instead')
set onFinishCallback(void Function()? callback) {
onComplete = callback;
}

/// Boolean indicators of the effect's state, their purpose is to ensure that
/// the `onStart()` and `onFinish()` callbacks are called exactly once.
bool _started;
Expand Down
38 changes: 0 additions & 38 deletions packages/flame/lib/src/game/mixins/fps_counter.dart

This file was deleted.

24 changes: 0 additions & 24 deletions packages/flame_test/lib/src/flame_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -125,30 +125,6 @@ class GameTester<T extends Game> {
);
}

/// Creates a [Game] specific test case with given [description]
/// which runs inside the Flutter test environment.
///
/// Use [verify] closure to make verifications/assertions.
@isTest
@Deprecated('Use testGameWidget instead, will be removed in v1.3.0')
void widgetTest(
String description,
WidgetVerifyFunction<T>? verify, {
bool? skip,
Timeout? timeout,
bool? semanticsEnabled,
dynamic tags,
}) {
testGameWidget(
description,
verify: verify,
skip: skip,
timeout: timeout,
semanticsEnabled: semanticsEnabled,
tags: tags,
);
}

/// Creates a [Game] specific test case with given [description]
/// which runs inside the Flutter test environment.
///
Expand Down

0 comments on commit 00ab347

Please sign in to comment.