-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for AssetsCache
#1998
Comments
Hi @spydon! I'd like to work on this :) |
Let me just verify that @ShwetaChauhan18 isn't already working on this since I recommended it to her. |
@spydon : I am taking this |
Thanks @spydon @ShwetaChauhan18 🎉 Let me know if any input I can add. |
ShwetaChauhan18
pushed a commit
to ShwetaChauhan18/flame
that referenced
this issue
Oct 4, 2022
- 🐛 Unit tests for AssetsCache
ShwetaChauhan18
pushed a commit
to ShwetaChauhan18/flame
that referenced
this issue
Oct 4, 2022
- 🐛 Unit tests for AssetsCache
7 tasks
ShwetaChauhan18
pushed a commit
to ShwetaChauhan18/flame
that referenced
this issue
Oct 4, 2022
- 🐛 Unit tests for AssetsCache
ShwetaChauhan18
pushed a commit
to ShwetaChauhan18/flame
that referenced
this issue
Oct 4, 2022
- 🐛 Unit tests for AssetsCache
ShwetaChauhan18
pushed a commit
to ShwetaChauhan18/flame
that referenced
this issue
Oct 4, 2022
- 🐛 Unit tests for AssetsCache
ShwetaChauhan18
pushed a commit
to ShwetaChauhan18/flame
that referenced
this issue
Oct 4, 2022
- 🐛 Unit tests for AssetsCache
ShwetaChauhan18
pushed a commit
to ShwetaChauhan18/flame
that referenced
this issue
Oct 4, 2022
- 🐛 Unit tests for AssetsCache
erickzanardo
pushed a commit
that referenced
this issue
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What could be improved
Currently the
AssetsCache
class doesn't have any tested, it would be good to improve the test coverage here. It is a lot simpler to write these tests than it sounds like, just have a look at how the tests for the other caches are written here:https://github.com/flame-engine/flame/tree/main/packages/flame/test/cache
Why should this be improved
So that we don't accidentally break anything when doing changes.
Good to know
You can run
melos coverage
to generate coverage files for Flame, just openpackages/flame/coverage/index.html
in your browser to see the results.Make sure that you comment on the issue that you will be working on this before starting to program.
To set up the Flame environment you need to follow the instructions in our contributing.md doc, if you have any problems setting up your environment (or other issues of course) feel free to ask for help in the Flame channel on our Discord server.
The text was updated successfully, but these errors were encountered: