Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for event mixins #2017

Closed
spydon opened this issue Oct 4, 2022 · 4 comments · Fixed by #2039
Closed

Unit tests for event mixins #2017

spydon opened this issue Oct 4, 2022 · 4 comments · Fixed by #2039

Comments

@spydon
Copy link
Member

spydon commented Oct 4, 2022

What could be improved

Currently the event mixins are not tested at, it would be good to improve the test coverage here.

Why should this be improved

So that we don't accidentally break anything when doing changes.

More information

https://github.com/flame-engine/flame/tree/main/packages/flame/lib/src/events/component_mixins
https://github.com/flame-engine/flame/tree/main/packages/flame/lib/src/events/flame_game_mixins
https://github.com/flame-engine/flame/tree/main/packages/flame/lib/src/events/game_mixins

Good to know

Make sure that you comment on the issue that you will be working on this before starting to program.

To set up the Flame environment you need to follow the instructions in our contributing.md doc, if you have any problems setting up your environment (or other issues of course) feel free to ask for help in the Flame channel on our Discord server.

Read through this to see how we organize the tests in flame:
https://docs.flame-engine.org/1.4.0/development/testing_guide.html

@spydon
Copy link
Member Author

spydon commented Oct 4, 2022

@ShwetaChauhan18 here is an issue you can tackle!

@ShwetaChauhan18
Copy link
Contributor

Ok, I am taking this

ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 6, 2022
 -  Unit tests for Event Mixin
    - `DragCallbacks`
    - `TapCallbacks`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 6, 2022
 -  Unit tests for Event Mixin
    - `DragCallbacks`
    - `TapCallbacks`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 6, 2022
 -  Unit tests for Event Mixin
    - `DragCallbacks`
    - `TapCallbacks`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 6, 2022
 -  Unit tests for Event Mixin
    - `DragCallbacks`
    - `TapCallbacks`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 7, 2022
 -  Unit tests for Event Mixin
    - `DragCallbacks`
    - `TapCallbacks`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 7, 2022
 -  Unit and Widget tests for Event Mixin
    - `DragCallbacks`
    - `TapCallbacks`
    - `MultiTouchDragDetector`
    - `MultiTouchTapDetector`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 7, 2022
 -  Unit and Widget tests for Event Mixin
    - `DragCallbacks`
    - `TapCallbacks`
    - `MultiTouchDragDetector`
    - `MultiTouchTapDetector`
@ShwetaChauhan18
Copy link
Contributor

@spydon : If you have any unit testing task then let me know

@spydon
Copy link
Member Author

spydon commented Oct 7, 2022

@spydon : If you have any unit testing task then let me know

This one is open if you want to tackle that one:
#2031

spydon pushed a commit that referenced this issue Oct 7, 2022
-  Unit and Widget tests for Event Mixin
    - `DragCallbacks`
    - `TapCallbacks`
    - `MultiTouchDragDetector`
    - `MultiTouchTapDetector`

Co-authored-by: Shweta_C <shweta.c@simformsolutions.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants