Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added FollowBehavior and ability for the new Camera to follow a component #1561

Merged
merged 15 commits into from
Apr 25, 2022
Merged

feat: Added FollowBehavior and ability for the new Camera to follow a component #1561

merged 15 commits into from
Apr 25, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Apr 21, 2022 •
edited
Loading

Description

  • Created FollowBehavior which can be attached to any component and cause that component to follow the given target;
  • Added CameraComponent methods follow(), stopFollowing(), and moveTo() which are similar to the existing Camera methods.

Still needed: tests, docs and examples.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@st-pasha st-pasha marked this pull request as ready for review April 24, 2022 08:13
wolfenrain
wolfenrain approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@wolfenrain wolfenrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spydon spydon merged commit b583388 into flame-engine:main Apr 25, 2022
@st-pasha st-pasha deleted the ps/camera-follow branch April 25, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@luanpotter luanpotter Awaiting requested review from luanpotter

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st-pasha @spydon @wolfenrain