fix: Focus handling with a scope on the GameWidget
#1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renancaraujo
force-pushed
the
renan/fix-focus-stuff
branch
from
7d7d997
to
87faaf6
Compare
4 tasks
renancaraujo
force-pushed
the
renan/fix-focus-stuff
branch
3 times, most recently
from
cf93232
to
2e41b85
Compare
renancaraujo
force-pushed
the
renan/fix-focus-stuff
branch
from
2e41b85
to
8926df2
Compare
erickzanardo
approved these changes
Oct 24, 2022
Comment on lines
+249
to
+250
| // ignore: avoid_redundant_argument_values | ||
| autofocus: true, |
There was a problem hiding this comment.
Suggested change
| // ignore: avoid_redundant_argument_values | |
| autofocus: true, |
There was a problem hiding this comment.
It's pretty good to keep this imho, it gives the reader of the test more context of what is being tested.
There was a problem hiding this comment.
Disagree with the suggestion, that is to explicitly show what that test tests.
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
spydon
changed the title
GameWidget
Hwan-seok
pushed a commit
to Hwan-seok/flame
that referenced
this pull request
Jan 5, 2023
This ignores keyboard events if the game widget doesn't have the primary focus. This allows focus nodes on overlay widgets to take precedence on keyboard resolving. Also, add focus scope in the game widget for when the overlay is removed, the focus goes back to the game. Also, add tests for GameWidget for all these cases and some more.
Hwan-seok
pushed a commit
to Hwan-seok/flame
that referenced
this pull request
Jan 5, 2023
This ignores keyboard events if the game widget doesn't have the primary focus. This allows focus nodes on overlay widgets to take precedence on keyboard resolving. Also, add focus scope in the game widget for when the overlay is removed, the focus goes back to the game. Also, add tests for GameWidget for all these cases and some more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ignores keyboard events if the game widget doesn't have the primary focus. This allows focus nodes on overlay widgets to take precedence on keyboard resolving.
Also, add focus scope in the game widget for when the overlay is removed, the focus goes back to the game.
Also, add tests for
GameWidgetfor all these cases and some more.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues
This is related to: