Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated oxygen dep to v0.3.1 and added removing components #3087

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix: Updated oxygen dep to v0.3.1 and added removing components #3087

merged 1 commit into from
Mar 20, 2024

Conversation

freewheelnat
Copy link
Contributor

Description

Updated oxygen dep to v0.3.1 and added call to new method to remove components.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality. --> I didn't see any tests for this package
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Oxygen issue: #18.

@freewheelnat freewheelnat changed the title chore: updated oxygen dep to v0.3.1 and added removing components Chore: updated oxygen dep to v0.3.1 and added removing components Mar 20, 2024
@freewheelnat freewheelnat changed the title Chore: updated oxygen dep to v0.3.1 and added removing components chore: Updated oxygen dep to v0.3.1 and added removing components Mar 20, 2024
spydon
spydon approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@spydon spydon changed the title chore: Updated oxygen dep to v0.3.1 and added removing components fix: Updated oxygen dep to v0.3.1 and added removing components Mar 20, 2024
@spydon spydon merged commit 8f50c92 into flame-engine:main Mar 20, 2024
9 of 11 checks passed
@freewheelnat freewheelnat deleted the fix/oxygen_remove-components-from-entities branch March 20, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freewheelnat @spydon