Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add background to ValueRoute example that captures events #3145

Merged
merged 4 commits into from
May 3, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented May 3, 2024

Description

Fixes #3143

In the future we should probably add another boolean that controls whether the events should be able to pass through the route or not, independent on whether the route below is rendered or not.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

doc/flame/router.md Outdated Show resolved Hide resolved
Co-authored-by: Renan <6718144+renancaraujo@users.noreply.github.com>
@spydon spydon merged commit 187c09f into main May 3, 2024
8 checks passed
@spydon spydon deleted the docs/route-transparent-events branch May 3, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: In ValuerRoute example you can click the transparent area to spawn multiple route
2 participants