Add support for building typings, using a different package manager, and specifying a custom build script #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
reviewed
May 12, 2021
|
|
||
| ### Assumptions | ||
|
|
||
| Your Javascript must be in a `js` folder, similar to how Flarum core and Flarum's first-party extensions are laid out. |
There was a problem hiding this comment.
Should this also be a variable?
askvortsov1
approved these changes
May 12, 2021
|
Yes! You can use act -j build -s GITHUB_TOKEN=xxxxx # Replace with a PATI turn off WiFi when it hits the Webpack build just to make sure it doesn't commit and push anywhere 🤪 |
If you've tested this, I'm happy with it. If it turns out not to work (it should work looking at the code), we can deal with it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
...but I have added a backcompat layer, even though I really shouldn't have to.
I have shifted syntax to use
withinstead ofenv, as this is designed for parameters.See README for new syntax. Core has been updated accordingly.
We really (like REALLY) should be using tags for our actions... this will break every repo this action is on.
Prerequisite of flarum/framework#2856.