Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue command fixes #1932

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Queue command fixes #1932

merged 1 commit into from
Nov 15, 2019

Conversation

luceos
Copy link
Member

@luceos luceos commented Nov 13, 2019

**Fixes #1879 **

Changes proposed in this pull request:

Allowed pass through of forever (and any other method) to the cache driver to fix the queue:restart command.

The queue:listen command already works.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@franzliedke franzliedke merged commit 99a0590 into master Nov 15, 2019
@franzliedke franzliedke deleted the dk/1879-queue-command-fixes branch November 15, 2019 14:01
luceos added a commit that referenced this pull request Feb 4, 2020
Adding a proxy callStatic on our simple implementation of the Manager class allows passing through calls like `forever()` to the underlying cache driver instance.
wzdiyb pushed a commit to wzdiyb/core that referenced this pull request Feb 16, 2020
Adding a proxy callStatic on our simple implementation of the Manager class allows passing through calls like `forever()` to the underlying cache driver instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queue listen and restart don't work
2 participants