Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 7.1 #2014

Merged
merged 4 commits into from
Feb 26, 2020
Merged

Conversation

askvortsov1
Copy link
Sponsor Member

@askvortsov1 askvortsov1 commented Feb 20, 2020

**Fixes #1988 **

Changes proposed in this pull request:

  • Drop support for PHP 7.1
  • Use v1 of wikimedia/less (more up to date)

Reviewers should focus on:

  • Wikimedia less is planning to release v3.0.0 shortly (Tag v3.0.0 wikimedia/less.php#26) to clear up their versioning. I think we shouldn't merge till then, and update our composer.json when they do.
  • In Require PHP 7.2+ #1988 (comment), Matt suggested upgrading Laravel to 6.x. When I tried doing this, our automated tests would fail when ran in github actions (although not on my local machine). Do we want to look into this update and compatibility with our setup? If so, here, or in a second PR?

@dsevillamartin
Copy link
Member

No to Laravel v6 - that will be a separate PR, most likely created by a core member as it requires changes to Flarum's internals.

Copy link
Contributor

@franzliedke franzliedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to delay this by waiting for the LESS library - can you remove the change to that library so that we can merge this now?

@askvortsov1
Copy link
Sponsor Member Author

I'd prefer not to delay this by waiting for the LESS library - can you remove the change to that library so that we can merge this now?

Done!

@franzliedke franzliedke merged commit 0d208dc into flarum:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require PHP 7.2+
3 participants