Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added post extender with type method, deprecated ConfigurePostTypes #2101

Merged
merged 11 commits into from
Nov 3, 2020
Merged

Added post extender with type method, deprecated ConfigurePostTypes #2101

merged 11 commits into from
Nov 3, 2020

Conversation

askvortsov1
Copy link
Sponsor Member

@askvortsov1 askvortsov1 commented Mar 29, 2020 •
edited
Loading

Fixes part of #1891 , #2418

Changes proposed in this pull request:

  • Added post types extender
  • Added integration tests
  • Deprecated ConfigurePostTypes

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@franzliedke franzliedke mentioned this pull request Apr 13, 2020
Closed
78 tasks
@stale
Copy link

stale bot commented Oct 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

@stale stale bot added the stale Issues that have had over 90 days of inactivity label Oct 9, 2020
@askvortsov1
Copy link
Sponsor Member Author

Not stale

@stale stale bot removed the stale Issues that have had over 90 days of inactivity label Oct 9, 2020
@tankerkiller125 tankerkiller125 removed the request for review from franzliedke October 29, 2020 12:06
clarkwinkelmann
clarkwinkelmann reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@clarkwinkelmann clarkwinkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A number of small comments.

src/Extend/Post.php Outdated Show resolved Hide resolved
src/Extend/Post.php Outdated Show resolved Hide resolved
src/Extend/Post.php Outdated Show resolved Hide resolved
src/Extend/Post.php Outdated Show resolved Hide resolved
@askvortsov1 askvortsov1 mentioned this pull request Oct 29, 2020
Merged
1 task
@askvortsov1 askvortsov1 linked an issue Nov 1, 2020 that may be closed by this pull request
Post Types Extender #2418
Closed
SychO9
SychO9 reviewed Nov 3, 2020
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for this PR but for consistency's sake we could also rename registerPostTypes to setPostTypes and make it protected.

@askvortsov1 askvortsov1 merged commit cee8784 into flarum:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 left review comments

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@clarkwinkelmann clarkwinkelmann clarkwinkelmann approved these changes

@luceos luceos Awaiting requested review from luceos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post Types Extender
4 participants
@askvortsov1 @tankerkiller125 @clarkwinkelmann @SychO9