Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix discussion unreadCount could be higher than commentCount #2195

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Fix discussion unreadCount could be higher than commentCount #2195

merged 2 commits into from
Jun 20, 2020

Conversation

w-4
Copy link
Contributor

@w-4 w-4 commented Jun 11, 2020

Fixes an issue

Happens when posts are deleted.

askvortsov1
askvortsov1 approved these changes Jun 15, 2020
View reviewed changes
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dsevillamartin
Copy link
Member

We may want a comment to clarify what this does and/or why it's needed.

@askvortsov1
Copy link
Sponsor Member

Done @datitisev

@askvortsov1 askvortsov1 merged commit cf4f2f2 into flarum:master Jun 20, 2020
@askvortsov1 askvortsov1 added this to the 0.1.0-beta.14 milestone Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkwinkelmann clarkwinkelmann clarkwinkelmann approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0-beta.14
Development

Successfully merging this pull request may close these issues.
4 participants
@w-4 @dsevillamartin @askvortsov1 @clarkwinkelmann