Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to register state of '0' as false for checkboxes #2210

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Add check to register state of '0' as false for checkboxes #2210

merged 2 commits into from
Jun 28, 2020

Conversation

askvortsov1
Copy link
Sponsor Member

Fixes #1395
Fixes #1478

Changes proposed in this pull request:

  • If the state supplied to a checkbox is '0', change it to false
  • Remove unnecessary conversion in AppearancePage

Reviewers should focus on:

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

tankerkiller125
tankerkiller125 approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@tankerkiller125 tankerkiller125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this work around for now

@askvortsov1 askvortsov1 merged commit e811592 into master Jun 28, 2020
@askvortsov1 askvortsov1 deleted the as/checkbox_accept_string_0 branch June 28, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@clarkwinkelmann clarkwinkelmann clarkwinkelmann approved these changes

@dsevillamartin dsevillamartin Awaiting requested review from dsevillamartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@askvortsov1 @tankerkiller125 @clarkwinkelmann