Fix number abbreviation when the number is n-thousand #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the method `abbreviateNumber` so that it behaves as stated in the JSDoc. Previously, an input of `1234` would have produced `1K`. With this change, the output will be `1.2K`.
askvortsov1
approved these changes
Aug 15, 2020
tankerkiller125
approved these changes
Aug 15, 2020
|
We'll merge this after the rewrite is merged. |
|
Actually, as there's no conflict, might as well merge this now. |
askvortsov1
pushed a commit
that referenced
this pull request
Sep 6, 2020
This commit fixes the method `abbreviateNumber` so that it behaves as stated in the JSDoc. Previously, an input of `1234` would have produced `1K`. With this change, the output will be `1.2K`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This commit fixes the method
abbreviateNumberso that it behaves as stated in the JSDoc.Previously, an input of
1234would have produced1K. With this change, the output will be1.2K.Reviewers should focus on:
/
Screenshot
/
Confirmed
composer test).