Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SMTP username and password shouldn't be required #2287

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Fix SMTP username and password shouldn't be required #2287

merged 1 commit into from
Sep 6, 2020

Conversation

phanlyhuynh
Copy link
Contributor

Fixes #2253

Changes proposed in this pull request:
Some SMTP servers do not require a password and possibly not a username either. The library handles username-less and password-less correctly so we shouldn't require them in the interface

Reviewers should focus on:
Nothing

Screenshot
The issue has images of the bug fixed by this PR.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

askvortsov1
askvortsov1 approved these changes Sep 6, 2020
View reviewed changes
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much!

clarkwinkelmann
clarkwinkelmann reviewed Sep 6, 2020
View reviewed changes
Copy link
Member

@clarkwinkelmann clarkwinkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, can someone confirm this works on a dev-master install?

@askvortsov1
Copy link
Sponsor Member

Code looks good, can someone confirm this works on a dev-master install?

Confirmed, will now merge

@askvortsov1 askvortsov1 merged commit 3f8432a into flarum:master Sep 6, 2020
askvortsov1 pushed a commit that referenced this pull request Sep 6, 2020
@phanlyhuynh @askvortsov1
Fix SMTP username and password shouldn't be required (#2287)
2f17b3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkwinkelmann clarkwinkelmann clarkwinkelmann left review comments

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@dsevillamartin dsevillamartin Awaiting requested review from dsevillamartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SMTP username and password shouldn't be required
4 participants
@phanlyhuynh @askvortsov1 @tankerkiller125 @clarkwinkelmann